[Docs Site] Fix leading spaces in anchors #19331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianNH
requested review from
a team,
46bit,
GregBrimble,
WalshyDev,
angelampcosta,
haleycode,
jherre,
jimhawkridge,
kodster28,
kokolocomotion1,
kristianfreeman,
marciocloudflare,
maxvp,
pedrosousa,
ranbel,
soheiokamoto and
victor-perov
as code owners
WalshyDev
approved these changes
Jan 21, 2025
github-actions
bot
added
size/s
product:analytics
github-actions
bot
assigned
GregBrimble,
haleycode,
kodster28,
kristianfreeman,
marciocloudflare and
maxvp
Deploying cloudflare-docs with
|
| Latest commit: |
1ef838c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b743c15e.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kian-pcx-13050.cloudflare-docs-7ou.pages.dev |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #16199
Resolves trailing spaces left behind after components are added (
# Foo <Component />being slugged asfoo-) and if a link is contained (## **400 Bad Request ([RFC7231](https://tools.ietf.org/html/rfc7231))**being slugged as400-bad-request-rfc7231-).This was due to leading spaces both when using components, or added when we insert
↗for external links.All other headings are not affected, as
"foo".replaceAll(" ↗", "").trimEnd();will still be"foo".